Re: [rfc 0/2] Introducing VmFlags field into smaps output

From: Cyrill Gorcunov
Date: Mon Oct 22 2012 - 16:56:37 EST


On Tue, Oct 23, 2012 at 12:50:48AM +0400, Pavel Emelyanov wrote:
> On 10/22/2012 11:29 PM, Andrew Morton wrote:
> > On Mon, 22 Oct 2012 23:14:52 +0400
> > Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:
> >
> >> Hi guys, during c/r sessions we've found that there is no way at
> >> the moment to fetch some VMA associated flags, such as mlock()
> >> and madvise(), thus the patches in this series intorduce new field
> >> into "smaps" output called VmFlags where all flags associated with
> >> the particular VMA is shown in two letter mnemonic.
> >>
> >> Strictly speaking for c/r we only need mlock/madvise bits but it
> >> has been said that providing just a few flags looks somehow inconsistent.
> >> So all flags are here now.
> >>
> >> Please review. Comments and complains are quite welcome!
> >
> > Sigh, it's still a pretty nasty-looking interface. Better ideas are
> > welcomed.
>
> Maybe just a string of two-letter short names like
>
> VmFlags: rd wr sh sr
>
> ?
>
> I.e. in a way flags line looks in cpuinfo file.

Yup, I think this will be shorter and more agreeable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/