Re: [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up()

From: JoonSoo Kim
Date: Mon Oct 22 2012 - 21:44:41 EST

2012/10/21 Tejun Heo <tj@xxxxxxxxxx>:
> On Sun, Oct 21, 2012 at 01:30:07AM +0900, Joonsoo Kim wrote:
>> Commit 63d95a91 ('workqueue: use @pool instead of @gcwq or @cpu where
>> applicable') changes an approach to access nr_running.
>> Thus, wq_worker_waking_up() doesn't use @cpu anymore.
>> Remove it and remove comment related to it.
>> Signed-off-by: Joonsoo Kim <js1304@xxxxxxxxx>
> I'm not sure whether I wanna remove or add WARN_ON_ONCE() on it. That
> part has gone through some changes and seen some bugs. Can we please
> do the following instead at least for now?
> if (!(worker->flags & WORKER_NOT_RUNNING)) {
> WARN_ON_ONCE(worker->pool->gcwq->cpu != cpu);
> atomic_inc(get_pool_nr_running(worker->pool));
> }

I have no objection to do this for now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at