Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZENfor PF_NOFREEZE or PF_FREEZER_SKIP tasks
From: Oleg Nesterov
Date: Tue Oct 23 2012 - 11:54:15 EST
On 10/22, Tejun Heo wrote:
> On Mon, Oct 22, 2012 at 08:34:53PM +0200, Oleg Nesterov wrote:
> > Hmm. We seem to "leak" PF_NOFREEZE if a kernel thread execs?
> > Perhaps do_execve_common() should do set_freezable() before return.
> > Or, at least, simply clear this flag along with PF_KTHREAD in
> > flush_old_exec().
> Ooh, ouch, definitely. We should clear that. Can you please make a
Sure... but what do you think is better?
I'd prefer to simply clear PF_NOFREEZE (without set_freezable), but
obviously this doesn't look exactly right from cgroup_freezer pov.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/