Re: [PATCH 02/26] pstore: add flags

From: Kees Cook
Date: Tue Oct 23 2012 - 12:54:36 EST

On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea <irina.tirdea@xxxxxxxxx> wrote:
> From: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Let the back end tweak pstore behaviour. Flags added are:
> Omit pstore heading lines from dumped data

I wonder if the default should be to not show headers, and to add this
flag to the backends that want the pstore-added header. I think the
more common case going forward will to be without headers since
backends should arguably storing metadata themselves.


> Default kmsg_bytes to ULONG_MAX
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>

Either way, this patch looks logically fine to me.


Kees Cook
Chrome OS Security
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at