Re: linux-next: build failure after merge of the akpm tree

From: Andrew Morton
Date: Tue Oct 23 2012 - 16:02:27 EST

On Tue, 23 Oct 2012 12:51:29 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> > btw, what's up with printk_syslog.h? It includes two header files which it
> > doesn't need but fails to include the two it *does* need: printk_log.h
> > and types.h.
> >
> >
> printk_syslog.c includes kernel.h (it includes types.h)
> and printk_log.h.
> I think printk_syslog.h doesn't need printk_log.h

A general rule is that the header file shouldn't know or care what else
it's includer has included. Ideally it shouldn't know or care what
else its includees have included, either.

A fun test would be

for i in *.h
echo $i > foo.c
make foo.o

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at