Re: [PATCH] dmaengine: imx-dma: fix missing unlock on error inimxdma_xfer_desc()

[Vinod Koul]

On Sun, 2012-10-21 at 19:58 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Add the missing unlock on the error handling path in function
> imxdma_xfer_desc().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/dma/imx-dma.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index f11b5b2..7d9554c 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -474,8 +474,10 @@ static int imxdma_xfer_desc(struct imxdma_desc *d)
>  			slot = i;
>  			break;
>  		}
> -		if (slot < 0)
> +		if (slot < 0) {
> +			spin_unlock_irqrestore(&imxdma->lock, flags);
>  			return -EBUSY;
> +		}
>  
>  		imxdma->slots_2d[slot].xsr = d->x;
>  		imxdma->slots_2d[slot].ysr = d->y;
> 
> 
> --
Thanks applied

-- 
Vinod Koul
Intel Corp.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/