Re: [PATCH v5] posix timers: allocate timer id per process

[Ingo Molnar]

* Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:

> On Wed, 2012-10-24 at 00:33 +0200, Thomas Gleixner wrote:
> > On Tue, 23 Oct 2012, Eric Dumazet wrote:
> > 
> > > On Tue, 2012-10-23 at 23:47 +0200, Thomas Gleixner wrote:
> > > 
> > > > Not so good to me.
> > > >  
> > > > > Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> > > > 
> > > > And that should be either an Acked-by or a Reviewed-by. You can't sign
> > > > off on patches which have not been submitted or transported by you.
> > > 
> > > I actually gave some input, provided a hash function, and so on.
> > > 
> > > So this SOB was valid. I do that all the time.
> > 
> > Not really. I recommend you to read the relevant file in Documentation
> > which covers what can have your SOB. 
> 
> OK I did that again, and found this :
> 
> The Signed-off-by: tag indicates that the signer was involved in the
> development of the patch, or that he/she was in the patch's delivery
> path.
> 
> 
> And I was involved in the development of the patch.
> 
> I understand you dont like it at all, so I'll remember not trying to
> help anymore in this area.

No, you are simply wrong and Linus would (rightfully) complain 
to *Thomas* if he added a SOB like that and pushed such a faulty 
commit to him. Linus has complained about such SOBs before and 
Thomas would be wrong to put them into commits.

SOBs get added if you are the developer of the patch or if you 
are actually one of the 'hops' in the route of the patch that 
gets it to Thomas. SOBs don't get added over email like you did 
and what Thomas pointed out was simply a maintainer's job to 
point out.

Adding credits for helping development get added via different 
tags, not via SOBs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/