Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split()

From: Martin K. Petersen
Date: Wed Oct 24 2012 - 12:34:17 EST


>>>>> "Vivek" == Vivek Goyal <vgoyal@xxxxxxxxxx> writes:

Vivek> Initially he had reordered the bio_pair fields but there were
Vivek> couple of issues. We could not assume that there is no padding
Vivek> between fields and secondly some of the initializtion of looked
Vivek> plain ugly.

Vivek> IMHO, introduction of bip_vec to fix this issue is small and
Vivek> cleaner then reordering fields.

I agree.

--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/