Re: [REGRESSION] uml: signal.c build errors

From: Matthew Leach
Date: Wed Oct 24 2012 - 15:49:04 EST



Richard Weinberger <richard@xxxxxx> writes:
> Am Wed, 24 Oct 2012 00:18:34 +0100
>> I have tracked this down to [1] where, indeed, the type of sig_info is
>> different; the second parameter in signal.c is 'siginfo_t' where as in
>> as-layout.h the second parameter's type is declared as 'struct
>> siginfo'.
>>
>> [1]: d3c1cfcdb43e023ab1b1c7a555cd9e929026500a
>
> Looks like we have to revert that commit.
> Moving everything to siginfo_t requires a non-trivial header cleanup
> and may introduce new regressions.
>
> Matthew, does the attached revert patch help?

The revert did remove the errors for the compilation of signal.c, so
that seems fine. I still get the following errors, however:

CC arch/um/os-Linux/sigio.o
CC arch/um/os-Linux/signal.o
CC arch/um/os-Linux/start_up.o
arch/um/os-Linux/start_up.c: In function âcheck_coredump_limitâ:
arch/um/os-Linux/start_up.c:338:16: error: storage size of âlimâ isnât known
arch/um/os-Linux/start_up.c:339:2: error: implicit declaration of function âgetrlimitâ [-Werror=implicit-function-declaration]
arch/um/os-Linux/start_up.c:339:22: error: âRLIMIT_COREâ undeclared (first use in this function)
arch/um/os-Linux/start_up.c:339:22: note: each undeclared identifier is reported only once for each function it appears in
arch/um/os-Linux/start_up.c:347:22: error: âRLIM_INFINITYâ undeclared (first use in this function)
arch/um/os-Linux/start_up.c:338:16: warning: unused variable âlimâ [-Wunused-variable]
cc1: some warnings being treated as errors
make[1]: *** [arch/um/os-Linux/start_up.o] Error 1
make: *** [arch/um/os-Linux] Error 2

Thanks,
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/