Re: [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support

From: Davide Ciminaghi
Date: Thu Oct 25 2012 - 08:22:47 EST


On Wed, Oct 24, 2012 at 01:49:55PM +0100, Mark Brown wrote:
> On Wed, Oct 24, 2012 at 02:31:18PM +0200, Davide Ciminaghi wrote:
> > On Tue, Oct 23, 2012 at 06:18:38PM +0100, Mark Brown wrote:
>
...
>
> > My opinion is that passing function pointers for
> > readable/writeable/precious/volatile methods could still be useful when
> > registers' features or access properties can change at runtime (for instance a
>
> This is essential for sparse register maps, really.

yes, I realized that when updating sta2x11-mfd to the new table driven approach
yesterday. One more thing I found is that you can have the case in which, for
instance, almost all readable registers are also writeable. To address such a
case, I added the possibility for a user to specify ranges for which a given
property is false, so that, in the above example, you first check whether a
given register belongs to the non-writeable region and then maybe skip the
other checks.
I'm sending a regmap patch in few minutes.

Thanks and regards
Davide

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/