Re: [PATCH v4 6/7] usb: dwc3-omap: Minor fixes to get dt working

[kishon]

Hi Benoit,

On Thursday 25 October 2012 07:11 PM, Benoit Cousson wrote:
> Hi Kishon,
>
> On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote:
> > Includes few minor fixes in dwc3-omap like populating the compatible
> > string in a correct way, extracting the utmi-mode property properly and
> > changing the index of get_irq since irq of core is removed from hwmod
> > entry.
> > Also updated the documentation with dwc3-omap device tree binding
> > information.
> >
> > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> > ---
> >   drivers/usb/dwc3/dwc3-omap.c |   14 ++++++--------
> >   1 file changed, 6 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> > index b84ddf3..10aad46 100644
> > --- a/drivers/usb/dwc3/dwc3-omap.c
> > +++ b/drivers/usb/dwc3/dwc3-omap.c
> > @@ -318,11 +318,10 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
> >   	struct resource		*res;
> >   	struct device		*dev = &pdev->dev;
> >
> > -	int			size;
> >   	int			ret = -ENOMEM;
> >   	int			irq;
> >
> > -	const u32		*utmi_mode;
> > +	u32			utmi_mode;
> >   	u32			reg;
> >
> >   	void __iomem		*base;
> > @@ -336,13 +335,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
> >
> >   	platform_set_drvdata(pdev, omap);
> >
> > -	irq = platform_get_irq(pdev, 1);
> > +	irq = platform_get_irq(pdev, 0);
>
> Cannot you use the name of the resource to avoid that kind of trick?

*name* is mostly used when we have multiple resource of the same type 
for a single device. Previously we were clubbing wrapper resources and 
core resources in a single hwmod device, so we had to use different 
indexing.
But with dt we have separated those under two different devices and 
hence we can always use index as '0'. But if you think we should have 
*name*, let me know, I can resend this patch :-)

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/