Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

From: Tejun Heo
Date: Thu Oct 25 2012 - 13:59:27 EST


Hello,

On Thu, Oct 25, 2012 at 10:54 AM, Aristeu Rozanski <aris@xxxxxxxxxx> wrote:
>> So, it returns 0 on success and 1 on failure, which in itself isn't a
>> particularly good idea.
>
> you mean it should return -ENODATA instead?

Yeap, this is a bug, right? We end up passing that 1 to the set_xattr caller.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/