Re: [ 08/31] use clamp_t in UNAME26 fix

From: Jonathan Nieder
Date: Fri Oct 26 2012 - 04:07:31 EST


Greg Kroah-Hartman wrote:
> On Thu, Oct 25, 2012 at 05:11:19PM -0700, Jonathan Nieder wrote:
>> Greg Kroah-Hartman wrote:

>>> v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 40;
>>> - copy = min(sizeof(buf), max_t(size_t, 1, len));
>>> + copy = clamp_t(size_t, len, 1, sizeof(buf));
>>> copy = scnprintf(buf, copy, "2.6.%u%s", v, rest);
>>
>> Does this have any effect at runtime? If not, why is it needed for
>> stable kernels?
>
> It's a bugfix for the previous patch in this area, fixing the build
> warning. I don't like adding stable patches that add new warnings :)

Ok, that's fair. Thanks for explaining.

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/