Re: [PATCH 01/16] math128: Introduce various 128bit primitives

From: Ingo Molnar
Date: Fri Oct 26 2012 - 07:11:25 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> I had hoped the u128 stuff might be elsewise useful, but if we
> don't want to go there, that's fine.

I think it needs a clearer usecase - and even then the 32-bit
behavior still looks rather horrible ...

So if we can escape all that with reasonable restrictions then
that's far better than taking on this kind of overhead for
32-bit systems. 32-bit still matters, we do the ktime_t
complications for 32-bit systems and that's for a far smaller
effect.

[ Would be nice to also stick in a WARN_ONCE() in the key
place(s) just in case, to make sure the overflow cannot happen
silently in the future. ]

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/