Re: [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38:error: expected ';' before 'pci_resource_start'

From: Greg KH
Date: Fri Oct 26 2012 - 15:54:09 EST


On Thu, Oct 25, 2012 at 02:14:21PM -0700, Joe Perches wrote:
> On Fri, 2012-10-26 at 02:30 +0800, Fengguang Wu wrote:
> > Hi Joe,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> > head: 334a57560cf08a04f530aa5546b4c9379c622544
> > commit: f23a277e64d8173e8cddd9e1903c3f9a564aaae5 [1/2] PCI: Convert pci_resource_<foo> macros to static inlines
> > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
> >
> > All error/warnings:
> >
> > drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci':
> > drivers/staging/telephony/ixj.c:7732:13: warning: assignment makes integer from pointer without a cast [enabled by default]
> > drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start'
> > --
> > drivers/scsi/gdth.c: In function 'gdth_init_pci':
> > drivers/scsi/gdth.c:1111:34: error: lvalue required as left operand of assignment
> >
> > vim +7732 drivers/staging/telephony/ixj.c
> >
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7726 if (pci_enable_device(pci))
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7727 break;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7728 j = new_ixj(pci_resource_start(pci, 0));
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7729 if (!j)
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7730 break;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7731
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 @7732 j->serial = (PCIEE_GetSerialNumber)pci_resource_start(pci, 2);
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7733 j->XILINXbase = j->DSPbase + 0x10;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7734 j->cardtype = QTI_PHONEJACK_PCI;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7735 j->board = *cnt;
> >
>
> Hi Fengguang.
>
> telephony is scheduled for removal one day soon.
> Likely no one has a working card.

Ah, I forgot about that one, I'll just go delete it, it's past when we
said it would go away, so we've waited long enough now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/