Re: [PATCH v2 1/3] drivers: bus: ocp2scp: add pdata support

From: Felipe Balbi
Date: Mon Oct 29 2012 - 02:16:18 EST


Hi,

On Sat, Oct 27, 2012 at 05:57:48PM +0530, kishon wrote:
> Hi,
>
> On Saturday 27 October 2012 01:29 AM, Felipe Balbi wrote:
> >Hi,
> >
> >On Fri, Oct 26, 2012 at 10:16:55AM -0700, Tony Lindgren wrote:
> >>* Felipe Balbi <balbi@xxxxxx> [121025 23:55]:
> >>>On Thu, Oct 25, 2012 at 10:44:47AM -0700, Tony Lindgren wrote:
> >>>>* Felipe Balbi <balbi@xxxxxx> [121024 23:24]:
> >>>>>Hi,
> >>>>>
> >>>>>On Wed, Oct 24, 2012 at 05:48:07PM -0700, Tony Lindgren wrote:
> >>>>>>* Tony Lindgren <tony@xxxxxxxxxxx> [121016 09:53]:
> >>>>>>>* Kishon Vijay Abraham I <kishon@xxxxxx> [121007 23:01]:
> >>>>>>>>ocp2scp was not having pdata support which makes *musb* fail for non-dt
> >>>>>>>>boot in OMAP platform. The pdata will have information about the devices
> >>>>>>>>that is connected to ocp2scp. ocp2scp driver will now make use of this
> >>>>>>>>information to create the devices that is attached to ocp2scp.
> >>>>>>>>
> >>>>>>>>Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> >>>>>>>
> >>>>>>>This fixes the regression on my panda es for musb port:
> >>>>>>>
> >>>>>>>Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> >>>>>>
> >>>>>>Looks like nobody has picked this one up and we need it to
> >>>>>>fix the musb regression on omap, so I'll queue these up.
> >>>>>
> >>>>>I don't seem to have the patches around in any mailbox :-(
> >>>>
> >>>>Bounced them to you. Do you have any better ideas for the
> >>>>-rc cycle to fix the MUSB regression on omap4?
> >>>
> >>>Well, there are two regressions that I know of. One is caused by the
> >>>mode1 DMA changes, which I'll just revert, and the other is the
> >>>missing platform_data support on the new PHY driver which these patches
> >>>are supposed to solve, right ?
> >>
> >>Yes that's it AFAIK.
> >
> >Kishon, any other patches I need to take to get MUSB working on v3.7 ?
>
> These should be good enough to get MUSB working..

nothing needed for omap-usb2.c ? That's great, cheers

--
balbi

Attachment: signature.asc
Description: Digital signature