Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

From: Naoya Horiguchi
Date: Mon Oct 29 2012 - 17:48:04 EST


On Mon, Oct 29, 2012 at 12:07:04PM -0700, Andi Kleen wrote:
> Theodore Ts'o <tytso@xxxxxxx> writes:
...
> > Also, if you're going to keep this state in memory, what happens if
> > the inode gets pushed out of memory?
>
> You lose the error, just like you do today with any other IO error.
>
> We had a lot of discussions on this when the memory error handling
> was originally introduced, that was the conclusuion.
>
> I don't think a special panic knob for this makes sense either.
> We already have multiple panic knobs for memory errors, that
> can be used.

Yes. I understand that adding a new knob is not good.
So this patch uses the existing ext4 knob without adding new one.

Thanks,
Naoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/