Re: [PATCH] Staging: android: binder: Fixed multi-line strings

From: Greg KH
Date: Mon Oct 29 2012 - 17:53:29 EST


On Fri, Oct 26, 2012 at 01:54:19PM +0530, Anmol Sarma wrote:
> if (vma == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed to "
> - "map pages in userspace, no vma\n", proc->pid);
> + pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> + proc->pid);
> goto err_no_vma;
> }
>
> @@ -585,8 +587,8 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
> BUG_ON(*page);
> *page = alloc_page(GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO);
> if (*page == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed "
> - "for page at %p\n", proc->pid, page_addr);
> + pr_err("%d: binder_alloc_buf failed for page at %p\n",
> + proc->pid, page_addr);
> goto err_alloc_page_failed;
> }
> tmp_area.addr = page_addr;

What's with the very wierd indentation here for the second line? Please
indent it properly, one space isn't ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/