Re: [PATCH 2/2] Remove VLAIS usage from gadget code

From: Joseph Glanville
Date: Thu Nov 01 2012 - 11:38:38 EST


On 31 October 2012 05:25, Behan Webster <behanw@xxxxxxxxxxxxxxxxxx> wrote:
> The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
> precludes the use of compilers which don't implement VLAIS (for instance the
> Clang compiler). This patch instead calculates offsets into the kmalloc-ed
> memory buffer using macros from valign.h.
>
> Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>

Linux only lists 2 requirements in the README.

1. GCC
2. PMMU ( granted this implies a much bigger list of requirements. :P )

Deficiences in Clangs GCC compatibility mode should be addressed
rather than pointlessly changing kernel code.
Possibly propose a patch to Clang instead?

Joseph.

--
CTO | Orion Virtualisation Solutions | www.orionvm.com.au
Phone: 1300 56 99 52 | Mobile: 0428 754 846
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/