Re: [PATCH 2/9] ARM: at91: Remove unused structat91sam9g45_isi_device and its resources

From: Lee Jones
Date: Sun Nov 04 2012 - 05:56:58 EST


On Sun, 04 Nov 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 23:02 Sat 03 Nov , Lee Jones wrote:
> > This the at91sam9g45_isi_device structure and its associated resources
> > were added in 2008 and have been unused ever since. Let's remove them.
> next time you need to Cc the matinaers

I did:

$ git show <sha1> | scripts/get_maintainer.pl
Russell King <linux@xxxxxxxxxxxxxxxx> (maintainer:ARM PORT)
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM SUB-ARCHITECT...)
linux-kernel@xxxxxxxxxxxxxxx (open list)

> NACK

Any particular reason?

> > Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> > arch/arm/mach-at91/at91sam9263_devices.c | 20 --------------------
> > 1 file changed, 20 deletions(-)
> >
> > diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> > index cb85da2..0562a9d 100644
> > --- a/arch/arm/mach-at91/at91sam9263_devices.c
> > +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> > @@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
> >
> > #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
> >
> > -struct resource isi_resources[] = {
> > - [0] = {
> > - .start = AT91SAM9263_BASE_ISI,
> > - .end = AT91SAM9263_BASE_ISI + SZ_16K - 1,
> > - .flags = IORESOURCE_MEM,
> > - },
> > - [1] = {
> > - .start = NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> > - .end = NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> > - .flags = IORESOURCE_IRQ,
> > - },
> > -};
> > -
> > -static struct platform_device at91sam9263_isi_device = {
> > - .name = "at91_isi",
> > - .id = -1,
> > - .resource = isi_resources,
> > - .num_resources = ARRAY_SIZE(isi_resources),
> > -};
> > -
> > void __init at91_add_device_isi(struct isi_platform_data *data,
> > bool use_pck_as_mck)
> > {
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/