Re: [PATCH 1/1] staging: usbip: remove an unnecessary lock inusbip_event_happened. The variable "happened" is local. So I think there isno need to lock here.

[Greg Kroah-Hartman]

On Mon, Nov 05, 2012 at 12:50:26PM +0800, Harvey Yang wrote:
> From: harvey.yang <harvey.huawei.yang@xxxxxxxxx>
> 
> 
> Signed-off-by: harvey.yang <harvey.huawei.yang@xxxxxxxxx>
> ---
>  drivers/staging/usbip/usbip_event.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c
> index d332a34..668f8e0 100644
> --- a/drivers/staging/usbip/usbip_event.c
> +++ b/drivers/staging/usbip/usbip_event.c
> @@ -116,10 +116,8 @@ int usbip_event_happened(struct usbip_device *ud)
>  {
>  	int happened = 0;
>  
> -	spin_lock(&ud->lock);
>  	if (ud->event != 0)
>  		happened = 1;
> -	spin_unlock(&ud->lock);
>  
>  	return happened;

Are you sure that the real fix for this isn't just making 'happened' a
static variable?  That would make more sense here.  Well maybe, the code
seems pretty dumb, it's hard to tell what this is supposed to be doing,
any ideas?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/