Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support
From: Mark Brown
Date: Mon Nov 05 2012 - 06:13:42 EST
On Mon, Nov 05, 2012 at 01:03:22PM +0200, Mika Westerberg wrote:
> On Mon, Nov 05, 2012 at 11:54:55AM +0100, Mark Brown wrote:
> > On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote:
> > > + strlcpy(spi->modalias, acpi_device_hid(adev), sizeof(spi->modalias));
> > > + if (info.gsi >= 0)
> > > + spi->irq = acpi_register_gsi(&adev->dev, info.gsi,
> > > + info.triggering, info.polarity);
> > > + request_module(spi->modalias);
> > request_module()? Why?
> The DT code does the same. I have no idea why it is there, really :-)
> I can remove it in the next version if you think it is not needed.
Well, if you can't identify what it does...
Attachment:
signature.asc
Description: Digital signature