Re: [PATCH] w1-gpio: Simplify & get rid of defines

From: Evgeniy Polyakov
Date: Mon Nov 05 2012 - 10:47:36 EST


Hi

On Wed, Oct 31, 2012 at 05:57:44PM +0200, Pantelis Antoniou (panto@xxxxxxxxxxxxxxxxxxxxxxx) wrote:
> There's no reason to have the OF defines; it complicates the driver.
> There's also no need for the funky platform_driver_probe.
>
> Add a few warnings in case there's a failure; helps us find out
> what went wrong.
>
> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>

Looks good to me, but I'm hardly an expert in omap platform.
Feel free to add my ack, but please submit this patch through
appropriate tree.
Thank you.

Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/