Re: [PATCH 3/7] OMAPDSS: APPLY: Fix the usage of wait_for_completion_timeout

[Tomi Valkeinen]

On 2012-11-06 19:22, Chuansheng Liu wrote:
> 
> The return value of wait_for_completion_timeout() is always
>> = 0 with unsigned int type.
> 
> So the condition "ret < 0" or "ret >= 0" is pointless.
> 
> Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx>
> ---
>  drivers/video/omap2/dss/apply.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c
> index 19d66f4..ec42a6a 100644
> --- a/drivers/video/omap2/dss/apply.c
> +++ b/drivers/video/omap2/dss/apply.c
> @@ -414,8 +414,6 @@ static void wait_pending_extra_info_updates(void)
>  	r = wait_for_completion_timeout(&extra_updated_completion, t);
>  	if (r == 0)
>  		DSSWARN("timeout in wait_pending_extra_info_updates\n");
> -	else if (r < 0)
> -		DSSERR("wait_pending_extra_info_updates failed: %d\n", r);
>  }
>  
>  int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)

Thanks. I'll apply this to omapdss tree to avoid any conflicts.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature