Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

[Ed Cashin]

On Nov 8, 2012, at 2:26 PM, Andrew Morton wrote:

> On Thu, 8 Nov 2012 11:29:32 -0500
> Ed Cashin <ecashin@xxxxxxxxxx> wrote:
> 
>> Signed-off-by: Ed Cashin <ecashin@xxxxxxxxxx>
> 
> Could you please prepare decent changelogs for the patches?  Several of
> these appear to be bugfixes but we have no description of the
> user-visible behavioural changes.  So nobody knows what the patches do,
> nor which kernel version(s) they should be merged into.

Yes, sure.  For this one, I Cc'ed Jens Axboe in part because although I believe that it is correct to use __blk_run_queue rather than to call the request handler directly, I am going on old information.  I'm not entirely sure what the user impact is when the request hander is called directly, other than perhaps a slight performance hit.

But I'd like to do the right thing.  Jens Axboe, if you have a comment about correctness or user impact, I'd like to include that information in the changelog for this commit.  Or if the change doesn't look right to you, I'd like to know that.

Thanks.

-- 
  Ed Cashin
  ecashin@xxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/