Re: [RFC] arm: memtest

From: Alexander Holler
Date: Fri Nov 09 2012 - 00:01:51 EST


Am 08.11.2012 23:39, schrieb Yinghai Lu:
On Thu, Nov 8, 2012 at 12:48 PM, Alexander Holler <holler@xxxxxxxxxxxxx> wrote:
Hello,

I've recently discovered the lack of the command line parameter memtest for
ARM. So I've made a patch.

But I have some questions:

1. arch/x86/mm/memtest.c looks platform independ.
The only thing why I don't use it for arm, is because it uses 64bit
pointers. Maybe it could be moved to mm/memtest.c. If so, the memtest32.c
I'm using (basically a copy of memtest.c) could be moved there too.

2. Because the below memtest32.c is basically a copy of
arch/x86/mm/memtest.c, I'm not sure if the mapping from physical to virtual
locations there does fit (always) for ARM too. I know almost as much about
the in-kernel memory organization on x86 as on ARM, which is not really that
much (some theory about TLBs, some source code explorations, ..., but I'm
working on it). ;)

We are using arch/x86/mm/memtest.c for x86 32bit and 64bit.

So it should be ok to use it with arm 32bit and 64bit directly.

It does. But in order to enable it on every boot, I wanted it to be as fast as possible.

Regards,

Alexander

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/