Re: Bisected regression: iterate_fd() selinux change affects flashplugin

From: Pavel Roskin
Date: Mon Nov 12 2012 - 11:57:00 EST


Quoting Eric Paris <eparis@xxxxxxxxxxxxxx>:

OMG this +1 -1 stuff is nuts...

iterate_fd passes fd+1 instead of the fd for the file? seriously?
ewwww. I see how this patch fixes it, but still, wouldn't some magic
or negative value for no entries found be better than having to
understand the crazy logics?

I agree. -ENOENT is both magic and negative :)

I tend to think now that iterate_fd() should be rewritten before it's too
late and all its current users should be cross-checked against the
code prior to the introduction of iterate_fd().

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/