Re: [PATCH] RFC: pinctrl: grab default handler with bus notifiers

From: Mark Brown
Date: Tue Nov 13 2012 - 01:35:52 EST


On Mon, Nov 12, 2012 at 01:21:40PM -0700, Stephen Warren wrote:
> On 11/11/2012 05:22 AM, Linus Walleij wrote:

> > Another solution that was discussed was whether to move
> > the default pinctrl handle and state grab to the device
> > core as an optional field in struct device itself, but
> > I'd like to first propose this less intrusive mechanism.

> I think doing that approach makes a lot more sense; wouldn't it
> completely avoid the issues with deferred probe that this notifier-based
> method can't solve? It would also be very much in line with e.g.
> dev_get_regmap() - if every resource that a driver required were handled
> like that, then deferred probe could be significantly isolated into the
> driver core rather than in every driver...

I have to say that I agree with this, notifiers seem to make life more
complicated for limited gain. Otherwise I guess we could enhance
notifiers so that they're able to trigger deferrals?

Attachment: signature.asc
Description: Digital signature