Re: [patch 4/7] fs, notify: Add procfs fdinfo helper v4

From: Cyrill Gorcunov
Date: Tue Nov 13 2012 - 02:21:59 EST


On Mon, Nov 12, 2012 at 05:00:17PM -0800, Andrew Morton wrote:
> >
> > static const struct file_operations inotify_fops = {
> > +#ifdef CONFIG_PROC_FS
> > + .show_fdinfo = inotify_show_fdinfo,
> > +#endif
> > .poll = inotify_poll,
> > .read = inotify_read,
> > .fasync = inotify_fasync,
> > @@ -427,6 +428,9 @@ static long fanotify_ioctl(struct file *
> > }
> >
> > static const struct file_operations fanotify_fops = {
> > +#ifdef CONFIG_PROC_FS
> > + .show_fdinfo = fanotify_show_fdinfo,
> > +#endif
> > .poll = fanotify_poll,
> > .read = fanotify_read,
> > .write = fanotify_write,
>
> Then remove these ifdefs.
>
> That's if you can be bothered. It's a bit of a party trick which
> doesn't make things much clearer IMO.

Sure, i'll update.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/