Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devicesfor bus-drivers.

From: Alexander Holler
Date: Tue Nov 13 2012 - 15:23:04 EST


Am 13.11.2012 19:55, schrieb Jean Delvare:
On Tue, 13 Nov 2012 19:06:07 +0100, Alexander Holler wrote:
This makes it possible to define i2c-devices at the kernel command line
or as a module parameter for bus-drivers which want to offer such
an functionality.

Drivers which are using it will have the a parameter named
devices with format devname1@addr1,devname2@addr2,...
e.g. devices=ds1307@0x68,pcf8563@0x51

No, no, no. We did that 10 years ago, killed all the code 3 years ago
[1], let's not do the same mistake again, please. We have a sysfs
interface for instantiating clients dynamically from user-space, it's
way more powerful and flexible than your proposal. Just try plugging two

So how do I define a device, e.g. an RTC which I want to have alive before userland starts? Currently imho not possible.

different i2c-tiny-usb adapters on the same system and see the new code
instantiate the wrong devices...

I know about that, but it probes and you don't have to use that parameter at all. I think some people can think for their self, especially those how would use such a parameter.

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=7f508118b1c1f9856a1c899a2bd4867a962b0225

I think my patch looks nicier.

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/