Re: [PATCH] regulator: core: Add locked version of regulator_put toavoid deadlock
From: Mark Brown
Date: Tue Nov 13 2012 - 18:25:54 EST
On Tue, Nov 13, 2012 at 04:30:40PM +0000, Charles Keepax wrote:
> -void regulator_put(struct regulator *regulator)
> +static void __regulator_put_locked(struct regulator *regulator)
Please do follow the coding style of the rest of the code; nothing else
is using __ for private functions.
Please also clarify the changelog - you're not adding a new API here,
you're fiddling about with the internals. Obviously regulator_put() is
always locked, you're just rearranging code inside the core here.
Attachment:
signature.asc
Description: Digital signature