Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver
From: Mark Brown
Date: Tue Nov 13 2012 - 22:05:05 EST
On Tue, Nov 13, 2012 at 10:01:26PM -0500, Laxman Dewangan wrote:
> >This does not seem sensible. Why would this be optional if it is
> >useful? In any case, what you're doing in the driver here is clearly
> >not the way forward.
> I was thinking of adding wake_enable in struct regmap_irq_chip and
> decide the wake support based on the value if wake_enable true or
> wake_base is non-zero. then wake support should be enable.
> The wake register write will happen only when wake_base is non-zero.
But to repeat my question why would this be optional?
Attachment:
signature.asc
Description: Digital signature