Re: [PATCH 2/2] cgroup, cpuset: remove cgroup_subsys->post_clone()

From: Glauber Costa
Date: Wed Nov 14 2012 - 03:20:01 EST


On 11/13/2012 09:27 PM, Tejun Heo wrote:
> From bbf2566f9f4fc79ff3320e83cafb69533efc9ea0 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@xxxxxxxxxx>
> Date: Tue, 13 Nov 2012 12:21:50 -0800
>
> Currently CGRP_CPUSET_CLONE_CHILDREN triggers ->post_clone(). Now
> that clone_children is cpuset specific, there's no reason to have this
> rather odd option activation mechanism in cgroup core. cpuset can
> check the flag from its ->css_allocate() and take the necessary
> action.
>
> Move cpuset_post_clone() logic to the end of cpuset_css_alloc() and
> remove cgroup_subsys->post_clone().
>
> Loosely based on Glauber's "generalize post_clone into post_create"
> patch.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Original-patch-by: Glauber Costa <glommer@xxxxxxxxxxxxx>
> Original-patch: <1351686554-22592-2-git-send-email-glommer@xxxxxxxxxxxxx>
> Cc: Glauber Costa <glommer@xxxxxxxxxxxxx>

I don't have any preference one way or the other. This patch seems to do
the job.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/