Re: [PATCH] mfd: arizona: Move chip reset to before register patch

From: Mark Brown
Date: Wed Nov 14 2012 - 05:51:18 EST


On Wed, Nov 14, 2012 at 10:48:54AM +0000, Charles Keepax wrote:
> On Wed, Nov 14, 2012 at 10:20:09AM +0900, Mark Brown wrote:

> > Just do a sync, make sure that we mark the map as dirty when we do the
> > reset via register write and it'll not have any effect anyway. We
> > should also check if we've got the LDO and use that for reset too
> > actually...

> The way the code is layed out at the moment if we don't
> successfully get the LDO we won't get as far as the register
> write reset. Meaning that if we can do the reset by cycling the
> power on the LDO is there any point in having the option to do
> the reset via a register write later?

No, we can't rely on having control over the LDO - it might be always
on. But we should ideally try to use it as a fallback, using a notifier
to find out if that worked or not.

Attachment: signature.asc
Description: Digital signature