Re: [PATCH 1/3] staging: line6: replace DEBUG_MESSAGES() withdev_dbg()

From: Dan Carpenter
Date: Wed Nov 14 2012 - 09:42:08 EST


On Sun, Nov 11, 2012 at 01:52:24PM +0100, Stefan Hajnoczi wrote:
> + dev_dbg(pod->line6.ifcdev,
> + "wrong size of channel dump message (%d instead of %d)\n",
> + pod->line6.message_length,
> + (int)sizeof(pod->prog_data) +
> + 7);

Better to get rid of the cast. You're already over the 80 character
limit so putting the "7);" on the line before is ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/