Re: drivers/char/random.c: variable type mismatch

From: H. Peter Anvin
Date: Wed Nov 14 2012 - 12:52:53 EST


On 11/14/2012 08:15 AM, Stephan Mueller wrote:

I agree with the argument of correlation.

So, if the reduction of values with a known lack of entropy is of
interest, why not change the jiffies variable type too? There we know
that only the lower 32 bits are really relevant. Therefore, wouldn't be
a structure of

struct {
unsigned jiffies;
unsigned cycles;
unsigned num;
} sample;

be more appropriate?


Probably. It doesn't make much difference, however.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/