Re: [PATCH 1/4] kernelshark: Fix bug with Plot CPU filtering

[David Sharp]

sorry for the dups... typoed Steve's domain.

On Wed, Nov 14, 2012 at 5:51 PM, David Sharp <dhsharp@xxxxxxxxxx> wrote:
> From: Venkatesh Pallipadi <venki@xxxxxxxxxx>
>
> Plot CPU filtering in kernelshark has the following bug:
> 1) Deselect CPU A from Plot CPU list
> 2) Plot gets updated with no CPU A
> 3) Deselect CPU B
> 4) Plot continues to have CPU B
>
> This is due to a bug in graph_plot_cpus_update_callback(),
> which seems to be checking old_all_cpus != new_all_cpus before doing any
> update. This condition is true on 1, but false on 2.
> Removing that check fixes the problem.
>
> Tested:
> Above sequence now does expected filtering.
>
> Google-bug-id: 4258610
> Signed-off-by: Venkatesh Pallipadi <venki@xxxxxxxxxx>
> Signed-off-by: David Sharp <dhsharp@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/