Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage ofwait_for_completion_timeout

From: Wolfram Sang
Date: Thu Nov 15 2012 - 04:29:56 EST



> > - if (timeout < 0) {
> > - dev_err(&dev->adev->dev,
> > - "wait_for_completion_timeout "
> > - "returned %d waiting for event\n", timeout);
> > - status = timeout;
> > - }
> > -
> No, it is wrong. You need to update the status variable in the case of timeout.

Looking at the patch context, such code comes later.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature