RE: [PATCH ] tbfadt.c: output warning only when 64bit 32bit addressof FACS/DSDT all have value but not equal to each other

[Moore, Robert]

Basically, the flow goes like this:

1) We convert the original FADT (multiple versions) to a common internal FADT.
2) Then we check the common internal FADT for errors/inconsistencies.

In this way, we don't need to have different error checking for different versions of the FADT, and this is probably not going to change.

One thing we are going to add is to make a decision on whether to favor a 32-bit address or a 64-bit address (if they are different) based upon the age of the machine/BIOS. This is for Windows compatibility.

Bob


> -----Original Message-----
> From: Ethan Zhao [mailto:ethan.kernel@xxxxxxxxx]
> Sent: Thursday, November 15, 2012 6:29 PM
> To: Moore, Robert
> Cc: Brown, Len; Zheng, Lv; LKML
> Subject: Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit
> address of FACS/DSDT all have value but not equal to each other
> 
> Bob,
>        Thanks for your detailed reviewing about the whole possible
> conditions.
>        I.C.  So that is impossible zero value for Xfacs /Xdsdt if
> facs/dsdt >0, for they are assigned in acpi_tb_convert_fadt(),  I need to
> move my eyes one line code higher to see why it yelled twice but not using
> the 32bit address at once in acpi_tb_convert_fadt().
>        Do you agree to move the checking code warning  and into
> acpi_tb_convert_fadt to make the code more simple and clear ? Or just keep
> it for more rework, more bug?
> 
> 
> Thanks,
> Ethan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/