Re: [PATCH] net/ethernet/intel/ixgbe/ixgbe_debugfs.c: fix errorhandling in ixgbe_dbg_reg_ops_read().

[Jeff Kirsher]

On Fri, 2012-11-16 at 04:26 +0100, Cyril Roelandt wrote:
> 
> copy_to_user() cannot return a negative value: it returns the number
> of bytes
> that could not be copied.
> 
> Return -EFAULT on failure rather than the number of bytes that could
> not be
> copied, as this seems more standard.
> 
> Signed-off-by: Cyril Roelandt <tipecaml@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-) 

Actually, I already have a similar patch in my queue reported by Dan
Carpenter, and created by Josh Hay which fixes this issue.  I should be
pushing the patch in my queue in the next week.  Here is the patch I am
referring to:

ixgbe: eliminate Smatch warnings in ixgbe_debugfs.c
    
This patch replaces calls to copy_to_user, copy_from_user, and the
associated logic, with calls to simple_read_from_buffer and
simple_write_to_buffer respectively.  This was done to eliminate
warnings generated by the Smatch static analysis tool.
    
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Josh Hay <joshua.a.hay@xxxxxxxxx>

Cheers,
Jeff

Attachment: signature.asc
Description: This is a digitally signed message part