Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionallycompiled on CONFIG_PM_SLEEP

[Jeff Garzik]

On 10/16/2012 10:59 AM, Yuanhan Liu wrote:
> This will fix warnings like following when CONFIG_PM_SLEEP is not set:
>
>          warning: 'xxx_suspend' defined but not used [-Wunused-function]
>          warning: 'xxx_resume' defined but not used [-Wunused-function]
>
> Because
> 	SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
>
> Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM).
>
> Cc: Jeff Garzik <jgarzik@xxxxxxxxx>
> Cc: Viresh Kumar <viresh.linux@xxxxxxxxx>
> Cc: linux-ide@xxxxxxxxxxxxxxx
> Signed-off-by: Yuanhan Liu <yuanhan.liu@xxxxxxxxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
>   drivers/ata/ahci_platform.c  |    2 +-
>   drivers/ata/pata_arasan_cf.c |    2 +-
>   drivers/ata/sata_highbank.c  |    2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)


applied



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/