Re: [PATCH 5/6] dma: ipu_idmac: reuse is_slave_xfer helper

From: Felipe Balbi
Date: Fri Nov 16 2012 - 09:03:09 EST


On Fri, Nov 16, 2012 at 03:59:18PM +0200, Andy Shevchenko wrote:

-ENOCOMMITLOG ??

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
> drivers/dma/ipu/ipu_idmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 6585537..c8d0254 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1347,7 +1347,7 @@ static struct dma_async_tx_descriptor *idmac_prep_slave_sg(struct dma_chan *chan
> chan->chan_id != IDMAC_IC_7)
> return NULL;
>
> - if (direction != DMA_DEV_TO_MEM && direction != DMA_MEM_TO_DEV) {
> + if (!is_slave_xfer(direction)) {
> dev_err(chan->device->dev, "Invalid DMA direction %d!\n", direction);
> return NULL;
> }
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
balbi

Attachment: signature.asc
Description: Digital signature