Re: [PATCH] autofs4 - use simple_empty() for empty directory check

[Linus Torvalds]

On Thu, Nov 15, 2012 at 8:15 PM, Ian Kent <ikent@xxxxxxxxxx> wrote:
>
> +static inline int __simple_empty(struct dentry *dentry)
> +{

This seems completely bogus.

It's a duplicate of the existing fs/libfs.c "simple_empty()" function,
but without taking the outer lock.

That kind of code duplication - and doing it in a totally different
file, and making it look autofs-specific - seems entirely wrong.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/