Re: [PATCH] autofs4 - use simple_empty() for empty directory check

[Ian Kent]

On Fri, 2012-11-16 at 07:45 -0800, Linus Torvalds wrote:
> On Thu, Nov 15, 2012 at 8:15 PM, Ian Kent <ikent@xxxxxxxxxx> wrote:
> >
> > +static inline int __simple_empty(struct dentry *dentry)
> > +{
> 
> This seems completely bogus.
> 
> It's a duplicate of the existing fs/libfs.c "simple_empty()" function,
> but without taking the outer lock.
> 
> That kind of code duplication - and doing it in a totally different
> file, and making it look autofs-specific - seems entirely wrong.

Sure, are you recommending I alter the fs/libfs.c functions to add a
function that doesn't have the outer lock, and have simple_empty() call
that, then use it in autofs?

Or are recommending I rework the autofs code?

Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/