Re: [PATCHv9 1/3] Runtime Interpreted Power Sequences

From: Alex Courbot
Date: Sun Nov 18 2012 - 21:29:04 EST


On Saturday 17 November 2012 19:38:50 Anton Vorontsov wrote:
> > +++ b/drivers/power/power_seq/Kconfig
> > @@ -0,0 +1,2 @@
> > +config POWER_SEQ
> > + tristate
>
> This really needs a proper Kconfig description and a help text, shortly
> describing the purpose of the subsystem.

Does it? The current state makes power seqs automatically selected by drivers
that need it, and they do not appear in the configuration menu. If we add a
description they will then become a visible item, so the logic would be to
make it user-selectable.

If that approach is preferred, I will also have to change pwm-backlight so
that it compiles without power sequences. Not that I mind, but I liked the
idea of not adding yet-another-option to the config menu.

Fixed the code according to all your other comments, thanks!

Alex.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/