Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion

From: Daniel Wagner
Date: Tue Nov 20 2012 - 10:16:43 EST


On 20.11.2012 16:13, Tejun Heo wrote:
Hello,

On Tue, Nov 20, 2012 at 04:09:22PM +0100, Daniel Wagner wrote:
Thanks for the explanation. I was pondering if the new size in power
of two could be a bit too excessive and the allocation step could be
linear, e.g. stick at 4096. target_id will increase linear,
therefore linear increase might also be enough, no?

Well, power-of-two resizing tends to behave relatively well under most
cases and slab allocations are binned by power-of-two sizes, so
linearly growing it doesn't really buy anything.

Convinced :)

Tested and Acked-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>

thanks,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/