Re: [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

[Greg Kroah-Hartman]

On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote:
> Let's put the line6 staging driver on a diet for Thanksgiving! :)

Yeah!

> Markus and I have discussed the MIDI processing that currently happens in the
> line6 driver.  This stuff really belongs in userspace where a library or
> utility can use ALSA MIDI APIs to control the device.  Moving MIDI processing
> to userspace has several benefits:
> 
> 1. The driver only handles PCM and MIDI I/O.  This means less kernel code.
> 
> 2. A large number of sysfs attributes can be removed.  These attributes exposed
>    MIDI state and driver code was necessary to sync and manage this state.
> 
> 3. It's easier for userspace to control the device, try out new MIDI commands,
>    etc when the driver acts as a dumb transport.
> 
> This patch series removes the sysfs attributes and then removes the state
> behind those attributes.  I have tried to make small incremental changes that
> can be reviewed easily.

Very nice, I'll queue these up on Monday, very good work, thanks so much
for doing this.

>  drivers/staging/line6/Kconfig       |  11 -
>  drivers/staging/line6/Makefile      |   2 -
>  drivers/staging/line6/control.c     | 995 ------------------------------------
>  drivers/staging/line6/control.h     | 195 -------
>  drivers/staging/line6/driver.c      |  20 -
>  drivers/staging/line6/dumprequest.c | 135 -----
>  drivers/staging/line6/dumprequest.h |  76 ---
>  drivers/staging/line6/midi.c        | 120 -----
>  drivers/staging/line6/midi.h        |  10 -
>  drivers/staging/line6/pod.c         | 846 +-----------------------------
>  drivers/staging/line6/pod.h         | 105 +---
>  drivers/staging/line6/variax.c      | 480 +----------------
>  drivers/staging/line6/variax.h      |  60 ---
>  13 files changed, 16 insertions(+), 3039 deletions(-)
>  delete mode 100644 drivers/staging/line6/control.c
>  delete mode 100644 drivers/staging/line6/control.h
>  delete mode 100644 drivers/staging/line6/dumprequest.c
>  delete mode 100644 drivers/staging/line6/dumprequest.h

I like seeing diffstats like that :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/