Re: [PATCH v3 11/12] x86, boot: add fields to support load bzImage and ramdisk high

From: H. Peter Anvin
Date: Thu Nov 22 2012 - 16:01:06 EST


Looks good to me.

Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

>On Wed, Nov 21, 2012 at 10:47 PM, Yinghai Lu <yinghai@xxxxxxxxxx>
>wrote:
>> On Wed, Nov 21, 2012 at 9:58 PM, H. Peter Anvin <hpa@xxxxxxxxx>
>wrote:
>>> Yes, lets...
>>>
>>>
>>>> also do you still think need to move ext_ramdisk...
>ext_cmd_line_ptr
>>>> from setup_header to boot_param ?
>>>
>
>how about:
>
>diff --git a/arch/x86/include/asm/bootparam.h
>b/arch/x86/include/asm/bootparam.h
>index 2ad874c..81b619e 100644
>--- a/arch/x86/include/asm/bootparam.h
>+++ b/arch/x86/include/asm/bootparam.h
>@@ -100,7 +100,10 @@ struct boot_params {
> __u8 _pad2[4]; /* 0x054 */
> __u64 tboot_addr; /* 0x058 */
> struct ist_info ist_info; /* 0x060 */
>- __u8 _pad3[16]; /* 0x070 */
>+ __u32 ext_ramdisk_image; /* 0x070 */
>+ __u32 ext_ramdisk_size; /* 0x074 */
>+ __u32 ext_cmd_line_ptr; /* 0x078 */
>+ __u8 _pad3[4]; /* 0x07C */
> __u8 hd0_info[16]; /* obsolete! */ /* 0x080 */
> __u8 hd1_info[16]; /* obsolete! */ /* 0x090 */
> struct sys_desc_table sys_desc_table; /* 0x0a0 */

--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/