Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

From: Mark Brown
Date: Fri Nov 23 2012 - 03:13:01 EST


On Fri, Nov 23, 2012 at 07:59:56AM +0100, Lothar Waßmann wrote:
> Mark Brown writes:

> > What is the actual bug here? This fix doesn't look obviously right, and
> > if we do need to move to -objs for some reason then the block ought to
> > be in the -objs section of the Makefile.

> As I mentioned in the part of my email that you didn't quote, if the
> sound driver is being compiled as module, the files imx-pcm-fiq.c or
> imx-pcm-dma.c which should be compiled as part of imx-pcm.o will not
> be touched by the compiler:

That's more detailed than your previous mail but you're still only
describing the symptom, not the what the actual error is or how it's
fixed...

Attachment: signature.asc
Description: Digital signature