Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

From: Samuel Ortiz
Date: Mon Nov 26 2012 - 16:07:27 EST


Hi Randy,

On Mon, Nov 26, 2012 at 11:21:33AM -0800, Randy Dunlap wrote:
> On 11/13/2012 05:35 AM, Linus Walleij wrote:
>
> > On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> >>
> >> Fix build errors when CONFIG_OF is not enabled by including
> >> <linux/of.h> (needs to be added in any case).
> >> An alternative fix could be to make the driver depend on OF.
> >>
> >> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
> >> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
> >> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> >> Cc: Rabin Vincent <rabin.vincent@xxxxxxxxxxxxxx>
> >> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> >
> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
>
>
>
> ping?
>
> This patch is still needed in linux-next.
Applied and pushed, thanks a lot.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/